Ticket #50 (closed defect: fixed)

Opened 19 months ago

Last modified 19 months ago

Layer based on SQL view breaks DescribeFeatureType request

Reported by: mno Owned by:
Priority: minor Version: SVN
Keywords: DescribeFeature sqlview Cc:
Triage Stage: Unreviewed State of Approval: Unnecessary
Attached Patches: None Complexity: Unknown
Compatibility: Unknown Specification: Unnecessary

Description

In rev. 185 in src/wfs/wfs_get_feature.c in line 96 we have:

pkey = ows_psql_id_column(o, layer_name); /* pkey could be NULL !!! */

as a note for layer based on SQL View, but in the src/wfs/wfs_describe.c in line 60 :

assert(id_name != NULL);

which breaks Describe Feature? and in turn saving features on other layer. Definition of the layer based on SQL view in config triggers this error.

Mike

Change History

Changed 19 months ago by ol

Mike,

Thanks for this detailled bug report !

I applied a fix as r311. I've checked it with a view and it seems okay.

But i will double check on OGC side if not to expose PK is really needed.

Changed 19 months ago by ol

  • status changed from new to closed
  • resolution set to fixed

After checks, i could remove the PK tests on Describe Feature Type?, commited as r312, and still okay on CITE tests...

Tks again Mike for this report !

Note: See TracTickets for help on using tickets.